Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix #1295] Covers validates_comparison_of in Rails/Validations #1297

Merged

Conversation

ChaelCodes
Copy link
Contributor

@ChaelCodes ChaelCodes commented Jun 13, 2024

Fixes #1295

Rails/Validation covers replacing old-style attribute validation macros with newer, more flexible validates calls. However currently, it doesn't check for validates_comparison_of. This covers validates_comparison_of, and adds a new test case for procs as arguments.


Before submitting the PR make sure the following are checked:

  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
  • Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.
  • [-] If this is a new cop, consider making a corresponding update to the Rails Style Guide.

Rails/Validation should include all old-style validation helpers,
including validates_comparison_of.
@ChaelCodes ChaelCodes force-pushed the 1295-rails-validations-covers-comparison branch from 99838b7 to 7e77248 Compare June 19, 2024 16:41
@koic koic merged commit dec8343 into rubocop:master Jun 21, 2024
14 checks passed
@koic
Copy link
Member

koic commented Jun 21, 2024

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rails/Validation does not cover validates_comparison_of
2 participants