Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rails/WhereNot add table/column split #409

Merged
merged 1 commit into from
Dec 18, 2020
Merged

Rails/WhereNot add table/column split #409

merged 1 commit into from
Dec 18, 2020

Conversation

mobilutz
Copy link
Contributor

@mobilutz mobilutz commented Dec 17, 2020

With this change, the cops suggestions and autocorrect splits a namespaces column reference into
table: { column: value }.

Example:

Comment.joins(:post).where.not('posts.title = ?', 'Title')

turns into ->

Comment.joins(:post).where.not(posts: { title: 'Title' })

PS: Almost the same as #406

  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Added an entry to the Changelog if the new code introduces user-observable changes. See changelog entry format.
  • The PR relates to only one subject with a clear title
    and description in grammatically correct, complete sentences.
  • Run bundle exec rake default. It executes all tests and RuboCop for itself, and generates the documentation.
  • If this is a new cop, consider making a corresponding update to the Rails Style Guide.

@mobilutz mobilutz changed the title Rails/WhereEquals add table/column split Rails/WhereNot add table/column split Dec 17, 2020
@mobilutz mobilutz marked this pull request as ready for review December 17, 2020 17:18
@koic koic merged commit 6af302b into rubocop:master Dec 18, 2020
@koic
Copy link
Member

koic commented Dec 18, 2020

Thanks!

@mobilutz mobilutz deleted the patch-2 branch April 12, 2021 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants