Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix #415] Make Rails/HasManyOrHasOneDependent accept association extension #416

Conversation

ohbarye
Copy link
Contributor

@ohbarye ohbarye commented Jan 6, 2021

Fixes #415

This pull request makes Rails/HasManyOrHasOneDependent accept combination of association extension and with_options.

class Person < ApplicationRecord
  with_options dependent: :destroy do
    has_many :foo do
      def bar
      end
    end
  end
end

The code above is going to be parsed as below.

s(:class,
  s(:const, nil, :Person),
  s(:const, nil, :ApplicationRecord),
  s(:block,
    s(:send, nil, :with_options,
      s(:hash,
        s(:pair,
          s(:sym, :dependent),
          s(:sym, :destroy)))),
    s(:args),
    s(:block,
      s(:send, nil, :has_many,
        s(:sym, :foo)),
      s(:args),
      s(:def, :bar,
        s(:args), nil))))

Before submitting the PR make sure the following are checked:

  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Added an entry to the Changelog if the new code introduces user-observable changes. See changelog entry format.
  • The PR relates to only one subject with a clear title
    and description in grammatically correct, complete sentences.
  • Run bundle exec rake default. It executes all tests and RuboCop for itself, and generates the documentation.
  • If this is a new cop, consider making a corresponding update to the Rails Style Guide.

@ohbarye ohbarye force-pushed the allow-combinatin-of-association-extension-and-with_options branch from 0d10d98 to b74094d Compare January 6, 2021 15:29
@koic koic merged commit f2613d6 into rubocop:master Jan 12, 2021
@koic
Copy link
Member

koic commented Jan 12, 2021

Thanks!

@ohbarye ohbarye deleted the allow-combinatin-of-association-extension-and-with_options branch January 13, 2021 02:11
@ohbarye
Copy link
Contributor Author

ohbarye commented Jan 13, 2021

Thanks for your review!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rails/HasManyOrHasOneDependent should allow combination of association extension and with_options
2 participants