Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark Rails/WhereExists as unsafe auto-correction #454

Merged

Conversation

koic
Copy link
Member

@koic koic commented Apr 2, 2021

Summary

This cop is unsafe because the behavior may change on the following case:

Author.includes(:articles).where(articles: {id: id}).exists?
#=> Perform `eager_load` behaviour (`LEFT JOIN` query) and get result.

Author.includes(:articles).exists?(articles: {id: id})
#=> Perform `preload` behaviour and `ActiveRecord::StatementInvalid` error occurs.

Additional Information

And this cop may be considered disabled by default as there is no consensus on the default style.


Before submitting the PR make sure the following are checked:

  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Added an entry to the Changelog if the new code introduces user-observable changes. See changelog entry format.
  • The PR relates to only one subject with a clear title
    and description in grammatically correct, complete sentences.
  • Run bundle exec rake default. It executes all tests and RuboCop for itself, and generates the documentation.
  • If this is a new cop, consider making a corresponding update to the Rails Style Guide.

@koic koic force-pushed the mark_rails_where_exists_as_unsafe_autocorrect branch 4 times, most recently from 6857bdd to e8725d0 Compare April 3, 2021 00:37
## Summary

This cop is unsafe because the behavior may change on the following case:

```ruby
Author.includes(:articles).where(articles: {id: id}).exists?
#=> Perform `eager_load` behaviour (`LEFT JOIN` query) and get result.

Author.includes(:articles).exists?(articles: {id: id})
#=> Perform `preload` behaviour and `ActiveRecord::StatementInvalid` error occurs.
```

## Additional Information

And this cop may be considered disabled by default as there is no consensus on the default style.

- rubocop#286
- rubocop#342
@koic koic force-pushed the mark_rails_where_exists_as_unsafe_autocorrect branch from e8725d0 to 6260b8b Compare April 8, 2021 07:17
@koic koic merged commit c7d2928 into rubocop:master Apr 11, 2021
@koic koic deleted the mark_rails_where_exists_as_unsafe_autocorrect branch April 11, 2021 05:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants