Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require RuboCop 1.7 or higher due to support obsoletion configuration #462

Merged
merged 1 commit into from
Apr 24, 2021

Conversation

koic
Copy link
Member

@koic koic commented Apr 21, 2021

Follow rubocop/rubocop#9206 and rubocop/rubocop#9143.

This PR requires RuboCop 1.7 or higher due to support obsoletion configuration and reverts 151b8a6.


Before submitting the PR make sure the following are checked:

  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Added an entry to the Changelog if the new code introduces user-observable changes. See changelog entry format.
  • The PR relates to only one subject with a clear title
    and description in grammatically correct, complete sentences.
  • Run bundle exec rake default. It executes all tests and RuboCop for itself, and generates the documentation.
  • If this is a new cop, consider making a corresponding update to the Rails Style Guide.

Follow rubocop/rubocop#9206 and
rubocop/rubocop#9143.

This PR requires RuboCop 1.7 or higher due to support obsoletion configuration
and reverts rubocop@151b8a6.
@koic koic merged commit 820b51c into rubocop:master Apr 24, 2021
@koic koic deleted the support_obsoletion_configuration branch April 24, 2021 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant