Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ReversibleMigrationMethodDefinition "Include" case #478

Merged
merged 1 commit into from
May 5, 2021
Merged

Fix ReversibleMigrationMethodDefinition "Include" case #478

merged 1 commit into from
May 5, 2021

Conversation

rhymes
Copy link
Contributor

@rhymes rhymes commented May 5, 2021

Include instead of include, otherwise the cop will target all Ruby files

Related to #457

@koic
Copy link
Member

koic commented May 5, 2021

The doc build is failing. Can you run rake generate_cops_documentation, commit the generated docs, and add the changelog entry? (Finally squash those commits into one.)

@rhymes
Copy link
Contributor Author

rhymes commented May 5, 2021

@koic done, now the tests have failed though :(

@dvandersluis
Copy link
Member

@rhymes you have to add a link to yourself at the bottom of the changelog.

eg.

[@rhymes]: https://github.com/rhymes

CHANGELOG.md Outdated Show resolved Hide resolved
`Include` instead of `include`, otherwise the cop will target all Ruby files

Update CHANGELOG.md

Co-authored-by: Koichi ITO <koic.ito@gmail.com>

Add myself at the bottom
@rhymes
Copy link
Contributor Author

rhymes commented May 5, 2021

@koic I think we're set! Thanks a lot for your assistance and guidance! 🔥

@koic koic merged commit a506670 into rubocop:master May 5, 2021
@koic
Copy link
Member

koic commented May 5, 2021

Thanks!

@koic koic mentioned this pull request May 6, 2021
@rhymes rhymes deleted the patch-1 branch May 6, 2021 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants