[Fix #43] Remove change_column_null from BulkChangeTable
#48
Conversation
|
@wata727 You are the original author of this cop and the developer who added this feature. Do you have any concerns about including this change? |
|
@koic Thank you for letting me know, and sorry I missed it. This change makes sense to me. Btw, I have a little concern if it is worthwhile to force this style for now. While it is worthwhile to get to know the |
|
@wata727 Thank you for your quick response and review. diff --git a/CHANGELOG.md b/CHANGELOG.md
index abdf246cb..58874e715 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -2,6 +2,10 @@
## master (unreleased)
+### Bug fixes
+
+* [#43](https://github.com/rubocop-hq/rubocop-rails/issues/43): Remove `change_column_null` method from `BulkChangeTable` cop offenses. ([@anthony-robin][])
+
## 2.0.1 (2019-06-08)
### Changes |
anthony-robin
force-pushed
the
remove_change_column_null_from_bulk_change_table
branch
from
a43a98a
to
d551dcb
Compare
|
@koic Thanks, I just rebased ! |
anthony-robin
force-pushed
the
remove_change_column_null_from_bulk_change_table
branch
from
d551dcb
to
0582a9d
Compare
CHANGELOG.md
Outdated
| @@ -2,6 +2,10 @@ | |||
|
|
|||
| ## master (unreleased) | |||
|
|
|||
| ### Bug fixes | |||
|
|
|||
| * [#43](https://github.com/rubocop-hq/rubocop-rails/issues/43): REMOVE `change_column_null` method from `BulkChangeTable` cop offenses. ([@anthony-robin][]) | |||
There was a problem hiding this comment.
Please replace REMOVE with Remove.
There was a problem hiding this comment.
Sorry, done !
The `change_column_null` method does not have corresponding method to use in the suggested `change_table` version. We should remove it from the offended methods list.
anthony-robin
force-pushed
the
remove_change_column_null_from_bulk_change_table
branch
from
0582a9d
to
8fa626d
Compare
anthony-robin
changed the title
change_column_null from BulkChangeTablechange_column_null from BulkChangeTable
|
Thanks! |
anthony-robin
deleted the
remove_change_column_null_from_bulk_change_table
branch
The
change_column_nullmethod does not have corresponding method touse in the suggested
change_tableversion.We should remove it from the offended methods list.
Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).and description in grammatically correct, complete sentences.
bundle exec rake default. It executes all tests and RuboCop for itself, and generates the documentation.