Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support auto-correction for Rails/Output #521

Merged
merged 1 commit into from
Jul 24, 2021

Conversation

koic
Copy link
Member

@koic koic commented Jul 22, 2021

This PR supports auto-correction for Rails/Output.


Before submitting the PR make sure the following are checked:

  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.
  • The PR relates to only one subject with a clear title
    and description in grammatically correct, complete sentences.
  • Run bundle exec rake default. It executes all tests and RuboCop for itself, and generates the documentation.
  • If this is a new cop, consider making a corresponding update to the Rails Style Guide.

@@ -2747,7 +2747,7 @@ scope :chronological, -> { order(created_at: :asc) }

| Enabled
| Yes
| No
| Yes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this shouldn't be considered a safe autocorrect. For example, depending on the Rails log level configuration, changing from puts to Rails.logger.debug could result in no output being shown.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's true! Thanks!

This PR supports auto-correction for `Rails/Output`.
@koic koic force-pushed the support_autocorrection_for_rails_output branch from 6f2782a to e00b742 Compare July 23, 2021 04:12
@koic koic merged commit 64f67c9 into rubocop:master Jul 24, 2021
@koic koic deleted the support_autocorrection_for_rails_output branch July 24, 2021 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants