Fix autocorrection bug when ::Hash
is used on Rails/IndexBy
and Rails/IndexWith
#867
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following 2 cops currently support both
Hash[...]
and::Hash[...]
, but the autocorrection for::Hash[...]
yields incorrect result. This is because it assumes onlyHash[
and removes the first 5 characters from source code.Rails/IndexBy
Rails/IndexWith
This problem was originally found at the following Pull Request:
Rails/DurationArithmetic
,Rails/IndexBy
,Rails/IndexWIth
, andRails/RequireDependency
#866 (comment)Before submitting the PR make sure the following are checked:
[Fix #issue-number]
(if the related issue exists).master
(if not - rebase it).bundle exec rake default
. It executes all tests and runs RuboCop on its own code.{change_type}_{change_description}.md
if the new code introduces user-observable changes. See changelog entry format for details.