Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix autocorrection bug when ::Hash is used on Rails/IndexBy and Rails/IndexWith #867

Merged
merged 1 commit into from
Nov 15, 2022

Conversation

r7kamura
Copy link
Contributor

@r7kamura r7kamura commented Nov 14, 2022

The following 2 cops currently support both Hash[...] and ::Hash[...] , but the autocorrection for ::Hash[...] yields incorrect result. This is because it assumes only Hash[ and removes the first 5 characters from source code.

  • Rails/IndexBy
  • Rails/IndexWith

This problem was originally found at the following Pull Request:


Before submitting the PR make sure the following are checked:

  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
  • Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.
  • If this is a new cop, consider making a corresponding update to the Rails Style Guide.

@r7kamura r7kamura changed the title Fix false-positives when ::Hash is used on Rails/FindBy and Rails/IndexWith Fix autocorrection bug when ::Hash is used on Rails/FindBy and Rails/IndexWith Nov 14, 2022
@r7kamura r7kamura changed the title Fix autocorrection bug when ::Hash is used on Rails/FindBy and Rails/IndexWith Fix autocorrection bug when ::Hash is used on Rails/IndexBy and Rails/IndexWith Nov 14, 2022
@koic koic merged commit 3d7228e into rubocop:master Nov 15, 2022
@koic
Copy link
Member

koic commented Nov 15, 2022

Great! Thanks!

@r7kamura r7kamura deleted the feature/index-method branch November 15, 2022 02:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants