Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a false positive for Rails/WhereMissing when left_joins(:foo)and where(foos: {id: nil}) separated by or, and #871

Merged
merged 1 commit into from
Dec 10, 2022

Conversation

ydah
Copy link
Member

@ydah ydah commented Nov 21, 2022

This PR is fix a false positive for Rails/WhereMissing when left_joins(:foo) and where(foos: {id: nil}) separated by or, and.

It is necessary to consider the following cases, which are separated by or or and.

Foo.left_joins(:foo).or(Foo.where(foos: {id: nil}))
Foo.where(foos: {id: nil}).and(Foo.left_joins(:foo))

Before submitting the PR make sure the following are checked:

  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
  • Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.
  • [-] If this is a new cop, consider making a corresponding update to the Rails Style Guide.

@ydah ydah force-pushed the fix/where_missing branch 2 times, most recently from 6ccc792 to 2783e35 Compare November 21, 2022 08:05
… and `where(foos: {id: nil})` separated by `or`, `and`

This PR is fix a false positive for `Rails/WhereMissing` when `left_joins(:foo)` and `where(foos: {id: nil})` separated by `or`, `and`.

It is necessary to consider the following cases, which are separated by `or` or `and`.

```ruby
Foo.left_joins(:foo).or(Foo.where(foos: {id: nil}))
Foo.where(foos: {id: nil}).and(Foo.left_joins(:foo))
```
@ydah
Copy link
Member Author

ydah commented Nov 28, 2022

Thank you for your review. I updated this PR.

@koic koic merged commit f94b235 into rubocop:master Dec 10, 2022
@koic
Copy link
Member

koic commented Dec 10, 2022

Thanks!

@ydah ydah deleted the fix/where_missing branch December 10, 2022 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants