Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix UnusedIgnoredColumns detection when using += #895

Merged
merged 1 commit into from
Jan 6, 2023

Conversation

lucthev
Copy link
Contributor

@lucthev lucthev commented Dec 24, 2022

Rails/IgnoredColumnsAssignment recommends adding to ignored_columns via +=, rather than simple assignment, but the += syntax isn't recognized by Rails/UnusedIgnoredColumns.

This PR fixes Rails/UnusedIgnoredColumns to work with +=.


Before submitting the PR make sure the following are checked:

  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
  • Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.
  • If this is a new cop, consider making a corresponding update to the Rails Style Guide.

@koic koic merged commit c0e3784 into rubocop:master Jan 6, 2023
@koic
Copy link
Member

koic commented Jan 6, 2023

Thanks!

@lucthev lucthev deleted the unused-ignored-cols branch January 7, 2023 03:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants