Fix an error for Rails/NegateInclude when there is no receiver
#920
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koic
reviewed
Jan 24, 2023
| private | ||
|
|
||
| def within_exclude_method?(node) | ||
| def_node = node.each_ancestor(:def, :defs).first |
fatkodima
force-pushed
the
negate_include-no-receiver
branch
from
9414529
to
994f368
Compare
koic
reviewed
Jan 24, 2023
| def self.foo | ||
| !include?(2) | ||
| ^^^^^^^^^^^^ Use `.exclude?` and remove the negation part. | ||
| end |
There was a problem hiding this comment.
That's what I noticed after reconsidering. It looks better to allow if there is no receiver because there may be user-defined include?, which may not have exclude?.
And can you separate the tests for def and defs?
There was a problem hiding this comment.
Updated to not raise an offense when there is no receiver. Now this PR is tiny 👍.
And that was actually an overkill from my side to detect cases like !include? inside def exclude?.
fatkodima
force-pushed
the
negate_include-no-receiver
branch
from
994f368
to
55381fd
Compare
fatkodima
force-pushed
the
negate_include-no-receiver
branch
from
55381fd
to
ca1c242
Compare
|
Great! Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an error when there is no receiver. And handles the case when it is used within
exclude?method (because correcting would cause infinite recursion).Example from rails: https://github.com/rails/rails/blob/d75fdd1c2f6002d62e5ecf65dda2942065f071f0/activesupport/lib/active_support/core_ext/string/exclude.rb#L10-L12