Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Rails/FilePath to detect offenses from complex string interpolation #989

Merged
merged 1 commit into from
Apr 25, 2023

Conversation

r7kamura
Copy link
Contributor

So far, this cop has only detected offenses from dstr nodes that end with str node, but I think there are offenses that would be missed if it did so. Therefore, I have changed the #on_dstr implementation to detect offenses even in examples such as the one I have added as a test case.


Before submitting the PR make sure the following are checked:

  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
  • Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.
  • If this is a new cop, consider making a corresponding update to the Rails Style Guide.

@koic koic merged commit 2235d8c into rubocop:master Apr 25, 2023
@koic koic mentioned this pull request Apr 25, 2023
9 tasks
@r7kamura r7kamura deleted the file-path-interpolation branch April 25, 2023 02:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants