Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude app/assets/**/* by default #992

Merged
merged 1 commit into from
Apr 26, 2023
Merged

Conversation

r7kamura
Copy link
Contributor

@r7kamura r7kamura commented Apr 25, 2023

This change is for the same reason as the following issue:

In a typical Rails application, this directory often contains a large number of non-ruby files, and I believe this optimization is reasonable for rubocop-rails to speed things up.


Before submitting the PR make sure the following are checked:

  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
  • Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.
  • If this is a new cop, consider making a corresponding update to the Rails Style Guide.

@@ -0,0 +1 @@
* [#992](https://github.com/rubocop/rubocop-rails/pull/992): Exclude `app/assets/**/*` by default. ([@r7kamura][])
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you rename this filename to changelog/change_exclude_app_assets_by_default.md?

To speed things up. This directory often contains a large number of files.
@koic koic merged commit 8611336 into rubocop:master Apr 26, 2023
4 checks passed
@koic
Copy link
Member

koic commented Apr 26, 2023

Thanks!

@r7kamura r7kamura deleted the exclude-app-assets branch April 26, 2023 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants