Restrict DuplicateAssociation cop to ActiveRecord #994
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mjankowski
force-pushed
the
duplicate-associations-only-on-activerecord
branch
from
fa6b9d7
to
06bc1a4
Compare
koic
reviewed
Jul 19, 2023
| @@ -227,4 +227,15 @@ class Post < ApplicationRecord | |||
| RUBY | |||
| end | |||
| end | |||
|
|
|||
| describe 'a class that does not descend from activerecord' do | |||
There was a problem hiding this comment.
That's just my two cents:
Suggested change
| describe 'a class that does not descend from activerecord' do | |
| describe 'a class that does not descend from Active Record' do |
|
Can you add a changelog entry? |
mjankowski
force-pushed
the
duplicate-associations-only-on-activerecord
branch
from
06bc1a4
to
e8a542a
Compare
|
Sure thing. Rebased against master, accepted the suggested changed, added changelog entry. |
|
Thanks! Can you squash your commits into one? |
Previously this cop would run against all classes, which led to false positives when the class was not descended from `ActiveRecord::Base` and thus might have acceptable use cases for repeating association declarations in ways that would not be acceptable in AR classes.
mjankowski
force-pushed
the
duplicate-associations-only-on-activerecord
branch
from
e8a542a
to
bc81740
Compare
|
Squashed. |
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously this cop would run against all classes, which led to false positives when the class was not descended from
ActiveRecord::Baseand thus might have acceptable use cases for repeating association declarations in ways that would not be acceptable in AR classes.