macOS/iOS: Various refactorings in application state #3720
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kchibisov
approved these changes
Jun 6, 2024
Comment on lines
+670
to
+671
| for window in application.windows().iter() { | ||
| if window.is_kind_of::<WinitUIWindow>() { |
There was a problem hiding this comment.
I'd rather not at this time, it's a safety condition for the unsafe just below, and moving it to filter makes it seem like they're less connected.
kchibisov
pushed a commit
that referenced
this pull request
Jun 10, 2024
I'm preparing to get rid of our application delegate in favour of registering notification observers, to do so I'm renaming `app_delegate.rs` to `app_state.rs`, and moving the functionality out of the Objective-C method into a normal method. Additionally, `AppState` previously implemented `Default`, but really, this was a hack done because someone (probably myself) was too lazy to write out the full initialization in `AppDelegate::new`.
kchibisov
pushed a commit
that referenced
this pull request
Jun 10, 2024
I'm preparing to get rid of our application delegate in favour of registering notification observers, to do so I'm renaming `app_delegate.rs` to `app_state.rs`, and moving the functionality out of the Objective-C method into a normal method. Additionally, `AppState` previously implemented `Default`, but really, this was a hack done because someone (probably myself) was too lazy to write out the full initialization in `AppDelegate::new`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm preparing to get rid of our application delegate in favour of registering notification observers, to do so I'm renaming
app_delegate.rstoapp_state.rs, and moving the functionality out of the Objective-C method into a normal method.Additionally,
AppStatepreviously implementedDefault, but really, this was a hack done because someone (probably myself) was too lazy to write out the full initialization inAppDelegate::new.This is (deliberately) a non-functional change.
EDIT: Builds up to #3758.