Fix payment view crashing due to failing stellar.expert fetch #1141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't re-throw a caught error in the
useWellKnownAccountshook but add the error to local state and make it accessible.This does not show a toast notification with a 'custom' message but a
Bad response (404) from stellar.expert servererror toast which is initiated by thewellKnownAccountsCache.suspend(testnet, fetchAccounts)function.I tried showing an error toast notification with a custom text but the
Bad response...error is thrown multiple times and the custom notification is overwritten rather quickly. So if we wanted to show a more detailed message we would have to either modify thecache.suspendfunction or bypass it with something else.Closes #1139.