Add sources of synthetic classes to sources jar #20904
Open
+33
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WojciechMazur
added
the
backport:accepted
sjrd
reviewed
Jul 3, 2024
Comment on lines
+3
to
+5
| /** The super-type of all types. | ||
| * | ||
| * See [[https://docs.scala-lang.org/scala3/reference/other-new-features/kind-polymorphism.html]]. |
There was a problem hiding this comment.
Nit:
Suggested change
| /** The super-type of all types. | |
| * | |
| * See [[https://docs.scala-lang.org/scala3/reference/other-new-features/kind-polymorphism.html]]. | |
| /** The super-type of all types. | |
| * | |
| * See [[https://docs.scala-lang.org/scala3/reference/other-new-features/kind-polymorphism.html]]. |
Same in the other files.
| * | ||
| * See [[https://docs.scala-lang.org/scala3/reference/other-new-features/kind-polymorphism.html]]. | ||
| */ | ||
| final abstract class AnyKind |
There was a problem hiding this comment.
It makes no sense for this type to be final. It definitely has subclasses, including AnyRef.
Suggested change
| final abstract class AnyKind | |
| abstract class AnyKind |
| * | ||
| * See [[https://docs.scala-lang.org/scala3/reference/new-types/intersection-types.html]]. | ||
| */ | ||
| type &[A, B] = A & B |
There was a problem hiding this comment.
This awfully looks like a circular definition. Consider leaving it abstract instead?
Suggested change
| type &[A, B] = A & B | |
| type &[A, B] |
Same for |.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #20073