Restore v0.16.0 id_pat #454
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
wcampbell0x2a
commented
Jun 19, 2024
wcampbell0x2a
commented
- When moving to the Read powered impl, I forced the user to use the same type as the id when reading into an id_pat With the use of Seek, we can now fix that and just seek back to the position before the id was read in the case of id_pat
Benchmark for 22221b6Click to view benchmark
|
* When moving to the Read powered impl, I forced the user to use the same type as the id when reading into an id_pat With the use of Seek, we can now fix that and just seek back to the position before the id was read in the case of id_pat
wcampbell0x2a
force-pushed
the
fix-id-pat
branch
from
c342e46
to
88e6e0b
Compare
Benchmark for 556c1e7Click to view benchmark
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.