refactor(dependency): add explicit dependency of slf4j-api in fiat-ldap module during upgrade to spring boot 2.7.x #1161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ap module during upgrade to spring boot 2.7.x While upgrading spring boot 2.7.18, encounter below error during compilation of fiat-ldap module: ``` > Task :fiat-ldap:compileJava FAILED /fiat/fiat-ldap/src/main/java/com/netflix/spinnaker/fiat/roles/ldap/LdapUserRolesProvider.java:54: error: package org.slf4j does not exist @slf4j ^ 1 error ``` The root cause is the removal of `slf4j-api` transitive dependency from org.springframework.ldap:spring-ldap-core:2.4.1 (via. org.springframework.security:spring-security-ldap:5.7.11, which is part of spring boot 2.7.18). So, adding the dependency explicitly. Before: ``` $ ./gradlew fiat-ldap:dI --dependency slf4j-api > Task :fiat-ldap:dependencyInsight org.slf4j:slf4j-api:1.7.36 Variant compile: | Attribute Name | Provided | Requested | |--------------------------------|----------|-------------------| | org.gradle.status | release | | | org.gradle.category | library | library | | org.gradle.libraryelements | jar | classes+resources | | org.gradle.usage | java-api | java-api | | org.gradle.dependency.bundling | | external | | org.gradle.jvm.environment | | standard-jvm | | org.gradle.jvm.version | | 11 | Selection reasons: - By constraint - Forced org.slf4j:slf4j-api:1.7.36 \--- io.spinnaker.kork:kork-bom:7.227.0 \--- compileClasspath org.slf4j:slf4j-api:1.7.32 -> 1.7.36 \--- org.springframework.ldap:spring-ldap-core:2.3.8.RELEASE +--- io.spinnaker.kork:kork-bom:7.227.0 | \--- compileClasspath \--- org.springframework.security:spring-security-ldap:5.6.10 +--- compileClasspath (requested org.springframework.security:spring-security-ldap) \--- io.spinnaker.kork:kork-bom:7.227.0 (*) ``` After: ``` $ ./gradlew fiat-ldap:dI --dependency slf4j-api > Task :fiat-ldap:dependencyInsight org.slf4j:slf4j-api:1.7.36 Variant compile: | Attribute Name | Provided | Requested | |--------------------------------|----------|-------------------| | org.gradle.status | release | | | org.gradle.category | library | library | | org.gradle.libraryelements | jar | classes+resources | | org.gradle.usage | java-api | java-api | | org.gradle.dependency.bundling | | external | | org.gradle.jvm.environment | | standard-jvm | | org.gradle.jvm.version | | 11 | Selection reasons: - By constraint - Forced org.slf4j:slf4j-api:1.7.36 \--- io.spinnaker.kork:kork-bom:sb2718-SNAPSHOT \--- compileClasspath org.slf4j:slf4j-api -> 1.7.36 \--- compileClasspath ```
dbyron-sf
approved these changes
May 29, 2024
|
included in #1165 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While upgrading spring boot 2.7.18, encounter below error during compilation of fiat-ldap module:
The root cause is the removal of
slf4j-apitransitive dependency from org.springframework.ldap:spring-ldap-core:2.4.1 (via. org.springframework.security:spring-security-ldap:5.7.11, which is part of spring boot 2.7.18). So, adding the dependency explicitly.Before:
After: