Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR: Fix windows kernel tunneling error #22223

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

hlouzada
Copy link
Contributor

@hlouzada hlouzada commented Jul 2, 2024

Description of Changes

  • Wrote at least one-line docstrings (for any new functions)
  • Added unit test(s) covering the changes (if testable)
  • Included a screenshot or animation (if affecting the UI, see Licecap)

Paramiko in Windows with/or Windows native SSH Client (Win32-OpenSSH) doesn't tunnel successfully, probably due to PowerShell/Win32-OpenSSH#999.

So it was used asyncssh that reimplements the Open SSH protocol in Python.

Affirmation

By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.

I certify the above statement is true and correct: @hlouzada

@pep8speaks
Copy link

pep8speaks commented Jul 2, 2024

Hello @hlouzada! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 99:80: E501 line too long (88 > 79 characters)

Line 189:80: E501 line too long (88 > 79 characters)
Line 236:80: E501 line too long (83 > 79 characters)
Line 367:80: E501 line too long (82 > 79 characters)
Line 503:80: E501 line too long (82 > 79 characters)
Line 571:80: E501 line too long (83 > 79 characters)

Line 138:80: E501 line too long (86 > 79 characters)
Line 139:80: E501 line too long (83 > 79 characters)
Line 169:80: E501 line too long (98 > 79 characters)
Line 200:80: E501 line too long (87 > 79 characters)
Line 258:80: E501 line too long (83 > 79 characters)
Line 260:80: E501 line too long (88 > 79 characters)
Line 288:80: E501 line too long (87 > 79 characters)
Line 316:80: E501 line too long (88 > 79 characters)

Comment last updated at 2024-07-03 22:39:31 UTC

@dalthviz
Copy link
Member

dalthviz commented Jul 2, 2024

Gave this a quick check on Windows and I'm being able to connect to the server on first try 👍 However, I'm getting an error related with the spyder-kernels version (need >= 3.0.0b7):

image

Probably the spyder-remote-server repo needs to be updated to follow latest constraints update since Spyder 6.0.0b2 was released? 🤔

@dalthviz dalthviz changed the title Fix windows kernel tunneling error PR: Fix windows kernel tunneling error Jul 2, 2024
@hlouzada
Copy link
Contributor Author

hlouzada commented Jul 2, 2024

Gave this a quick check on Windows and I'm being able to connect to the server on first try 👍 However, I'm getting an error related with the spyder-kernels version (need >= 3.0.0b7):

image

Probably the spyder-remote-server repo needs to be updated to follow latest constraints update since Spyder 6.0.0b2 was released? 🤔

Exactly. I've just updated spyder-remote-kernels to install spyder-kernels=3.0.0b7. Please reinstall the remote server and test again.

@dalthviz
Copy link
Member

dalthviz commented Jul 3, 2024

Gave this another check and things are working for me on my Windows machine 👍 I'm now able to connect to a docker container and start a console connected to a kernel create using the spyder-remote-server 🎉

image

@dalthviz dalthviz requested a review from ccordoba12 July 3, 2024 20:10
@hlouzada hlouzada force-pushed the fix-windows-kernel-tunneling-error branch from 9ab05c6 to 9eadbc9 Compare July 3, 2024 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants