Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding emergency registration procedure #1060

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

kbaccar
Copy link

@kbaccar kbaccar commented Dec 16, 2022

  • Added IMEI based emergency registration for srsUE
  • Added a new parameter nas.enable_emergency_reg (default = false)

@CLAassistant
Copy link

CLAassistant commented Dec 16, 2022

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ kbaccar
❌ Karim Baccar


Karim Baccar seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

Copy link
Collaborator

@andrepuschmann andrepuschmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey, thanks for your contribution. I have a few comments, see below. You definitely should check your clang-format config. Thanks

@@ -67,6 +67,8 @@ class nas_5g_args_t
std::string ia5g;
std::string ea5g;
std::vector<pdu_session_cfg_t> pdu_session_cfgs;
bool emergency_registration;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is for 5g only, so maybe call it emergency_registration_5g?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FIxed, changed it to emergency_registration_5g.

int nas_5g::send_registration_request()
{

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

srsue/src/stack/upper/nas_5g.cc Outdated Show resolved Hide resolved

reg_req.ue_security_capability_present = true;
fill_security_caps(reg_req.ue_security_capability);

if (initial_registration_request_stored.pack(pdu) != SRSASN_SUCCESS) {
logger.error("Failed to pack registration request");
return SRSRAN_ERROR;
logger.error("Failed to pack registration request");
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

indent wrong

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

@@ -65,11 +65,7 @@ srsran::proc_outcome_t nas_5g::pdu_session_establishment_procedure::init(const u
srsran::proc_outcome_t nas_5g::pdu_session_establishment_procedure::react(
const srsran::nas_5g::pdu_session_establishment_accept_t& pdu_session_est_accept)
{
// TODO check the pdu session values
if (pdu_session_est_accept.dnn_present == false) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

leave the if maybe but add and not cfg.emergency_registration?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added a new member to the nas_5g_procedure called emegency_pdu_session that was intialized during init function from the emergency_registration argument.

@andrepuschmann
Copy link
Collaborator

Hey @kbaccar, thanks for the PR again. We'll release the 23.04 version of srsRAN 4G in a few days that will include a few changes in the files your PR touched. Would be good if you could rebase your PR on top of it once it's out.

@kbaccar
Copy link
Author

kbaccar commented May 23, 2023

@andrepuschmann Conflict fixed, branch have been merged to master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants