Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ANCHOR-544] Fix date fields in SEP-12 PUT /customer #1232

Merged
merged 3 commits into from
Dec 14, 2023

Conversation

philipliu
Copy link
Contributor

Description

This changes the id_issue_date and id_expiration_date type to a String instead of an Instant. Validation has been added to these fields to ensure they are in ISO-8601 date-only format before passing it to the business server.

Context

SEP-9 date fields should be in ISO-8601 date-only format.

Testing

  • ./gradlew test

Documentation

N/A

Known limitations

N/A

@philipliu philipliu marked this pull request as ready for review December 13, 2023 23:25
@Ifropc
Copy link
Contributor

Ifropc commented Dec 14, 2023

Shouldn't we accept ISO 8601 date time too for backward compatibility? Not sure if anybody uses it right not, but simple regex replacement of "T.*", "" could be sufficient

@philipliu
Copy link
Contributor Author

@Ifropc Good point. I think there is less room for error if we avoid using regex, so I'll parse instead.

@Ifropc
Copy link
Contributor

Ifropc commented Dec 14, 2023

Ideally we would want to pass ISO-8601 date-only format to business server but I think date-time is acceptable

@philipliu philipliu merged commit ab5601f into stellar:develop Dec 14, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants