Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ANCHOR-549] Add demo wallet support to SEP-6 reference #1251

Merged
merged 8 commits into from
Jan 10, 2024
Merged

[ANCHOR-549] Add demo wallet support to SEP-6 reference #1251

merged 8 commits into from
Jan 10, 2024

Conversation

philipliu
Copy link
Contributor

@philipliu philipliu commented Jan 9, 2024 •
edited
Loading

Description

This updates the SEP-6 reference implement to support wallet testing. The following was fixed:

  • More than one deposit/withdraw be requested without restarting the server
  • Empty amount requests are now supported

Context

This is required for wallet testing.

Testing

  • ./gradlew test
  • Testing with the demo wallet

Documentation

N/A

Known limitations

N/A

@philipliu philipliu marked this pull request as ready for review January 10, 2024 00:16
lijamie98
lijamie98 approved these changes Jan 10, 2024
View reviewed changes
Copy link
Collaborator

@lijamie98 lijamie98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@philipliu philipliu merged commit 7045ae8 into stellar:develop Jan 10, 2024
7 checks passed
@philipliu philipliu deleted the fix/anchor-549-reference-server branch January 10, 2024 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lijamie98 lijamie98 lijamie98 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@philipliu @lijamie98