[ANCHOR-579][Quick Fix] Fix Sep10 config home_domain coexist error #1256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JiahuiWho
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix sep10 config reading
home_domainandhome_domainsfrom different resource and causing conflictingContext
Currently Sep10Config will throw error if
home_domainsis set in env config, because it is also readinghome_domainfrom default config, and these two field cannot coexist.This is a quick fix. Will deprecate
home_domainand move to usehome_domainsonly in 3.0Testing
./gradlew testTested with default config and multi-tenant config provided by SDP team, both work properly.