Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Fix the V14_udpate_sep24_fields.sql not applied correctly and turned on migration file naming validation #1296

Merged
merged 5 commits into from
Mar 19, 2024

Conversation

lijamie98
Copy link
Collaborator

Description

Fix the V14_udpate_sep24_fields.sql not applied correctly. Rename V14_update_sep24_fields.sql to V15_update_sep24_fields.

Context

Bug fixes

Copy link
Contributor

@philipliu philipliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's bump the version too.

@lijamie98 lijamie98 changed the title [BUG] Fix the V14_udpate_sep24_fields.sql not applied correctly. [BUG] Fix the V14_udpate_sep24_fields.sql not applied correctly and turned on migration file naming validation Mar 19, 2024
@JiahuiWho
Copy link
Contributor

JiahuiWho commented Mar 19, 2024

I think you also need to drop the field from JdbcSep24Transaction

@lijamie98
Copy link
Collaborator Author

lijamie98 commented Mar 19, 2024

Let's bump the version too.

Yeah, should probably create the release branch first. I will bump the version in the release process.

@lijamie98 lijamie98 merged commit a42b772 into stellar:develop Mar 19, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants