-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ANCHOR-687] Upgrade to JDK-17 #1367
[ANCHOR-687] Upgrade to JDK-17 #1367
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@@ -1,4 +1,4 @@ | |||
ARG BASE_IMAGE=gradle:7.6.4-jdk11-alpine | |||
ARG BASE_IMAGE=gradle:7.6.4-jdk17-alpine |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should upgrade gradle to latest in 3.0 if we haven't already
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This makes least impact to 2.x
. We can do major upgrades in v3.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agree!
if (detail instanceof Exception) { | ||
Exception ex = (Exception) detail; | ||
|
||
logMessageWithJson( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this required now? Does the message get collapsed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is because logMessageWithJson(message, detail, getLogger()::error);
failed serializing the message
field if detail
is an exception.
That's the reason that we have expand it manually.
…grade-to-jdk17-27
Description
Context
Testing
./gradlew test
Documentation
Update
How to Contribute
doc.Known limitations
N/A