WIP: Support MDX2 #380
Closed
WIP: Support MDX2 #380
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IanVS
commented
May 17, 2022
| }, | ||
| async transform(src: string, id: string, ssr) { | ||
| if (!/\.mdx?$/.test(id)) return src; | ||
| const code = await compile(src, { skipCsf: true }); |
There was a problem hiding this comment.
We won't want to skipCsf in the final version, but it avoids some errors for now.
|
Replaced by #377 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an alternate approach to #377 that attempts to add support for MDX2 (#234).
This applies a similar approach as vite-plugin-mdx, sending the output of
@storybook/mdx2-csfthrough the@vitejs/plugin-babeltransform in order to add react refresh support. This currently blows up because@storybook/mdx2-csfprocesses the code with babel, which adds its own react-transform. @shilman has indicated that it shouldn't be a problem to add a method or flag that would expose the src without the babel transforms.