Replace deprecated padding-line-between-statements with `@stylistic…

…/js/padding-line-between-statements` (#278)

CHANGELOG.md

@@ -2,6 +2,7 @@
 
 ## Head
 
+- Changed: replace deprecated `padding-line-between-statements` with `@stylistic/js/padding-line-between-statements`.
 - Fixed: missing `funding` field in `package.json`.
 
 ## 21.0.0

__tests__/index.test.js

@@ -9,6 +9,8 @@ const { ESLint } = require('eslint');
 const config = require('../index');
 const { isObject } = require('./helper');
 
+const newESLint = () => new ESLint({ baseConfig: config, useEslintrc: false, fix: true });
+
 test('basic properties of config', () => {
 	assert(isObject(config.parserOptions));
 	assert(isObject(config.env));
@@ -17,8 +19,48 @@ test('basic properties of config', () => {
 });
 
 test('load config in ESLint to validate all rule syntax is correct', async () => {
-	const eslint = new ESLint({ baseConfig: config, useEslintrc: false });
-	const results = await eslint.lintText('var foo\n');
+	const results = await newESLint().lintText('var foo\n');
 
 	assert(results);
 });
+
+test('padding-line-between-statements', async () => {
+	const code = `
+const asdf = 'dfsdf';
+function xxcv() {
+	const sdfsdf = 'sdfsdf';
+	return sdfsdf;
+}
+for (let i = 0; i < 10; i++) {
+	console.log(i);
+}
+const asdfsfd = 'sdfsdf';
+if (true) {
+	console.log('true');
+}
+`;
+
+	const results = await newESLint().lintText(code);
+
+	const expected = `
+const asdf = 'dfsdf';
+
+function xxcv() {
+	const sdfsdf = 'sdfsdf';
+
+	return sdfsdf;
+}
+
+for (let i = 0; i < 10; i++) {
+	console.log(i);
+}
+
+const asdfsfd = 'sdfsdf';
+
+if (true) {
+	console.log('true');
+}
+`;
+
+	assert.equal(results[0].output, expected);
+});

index.js

@@ -16,6 +16,7 @@ module.exports = {
 		'plugin:regexp/recommended',
 		'prettier',
 	],
+	plugins: ['@stylistic/js'],
 	rules: {
 		'array-callback-return': 'error',
 		'dot-notation': 'error',
@@ -57,7 +58,16 @@ module.exports = {
 		'object-shorthand': 'error',
 		'one-var': ['error', 'never'],
 		'operator-assignment': 'error',
-		'padding-line-between-statements': [
+		'prefer-arrow-callback': 'error',
+		'prefer-object-spread': 'error',
+		'prefer-regex-literals': 'error',
+		'prefer-rest-params': 'error',
+		'prefer-spread': 'error',
+		'prefer-template': 'error',
+		'sort-imports': ['error', { allowSeparatedGroups: true }],
+
+		// Migrated from the deprecated built-in 'padding-line-between-statements'
+		'@stylistic/js/padding-line-between-statements': [
 			'error',
 			// Require blank lines after all directive prologues (e. g. 'use strict')
 			{
@@ -101,13 +111,6 @@ module.exports = {
 				next: '*',
 			},
 		],
-		'prefer-arrow-callback': 'error',
-		'prefer-object-spread': 'error',
-		'prefer-regex-literals': 'error',
-		'prefer-rest-params': 'error',
-		'prefer-spread': 'error',
-		'prefer-template': 'error',
-		'sort-imports': ['error', { allowSeparatedGroups: true }],
 
 		// Avoid a global variable unique to Node.js.
 		'n/prefer-global/process': ['error', 'never'],

package.json

@@ -34,6 +34,7 @@
   },
   "prettier": "@stylelint/prettier-config",
   "dependencies": {
+    "@stylistic/eslint-plugin-js": "^2.2.2",
     "eslint-config-prettier": "^9.1.0",
     "eslint-plugin-n": "^17.7.0",
     "eslint-plugin-regexp": "^2.6.0"