Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: handle failed global node_modules resolution #314

Merged
merged 1 commit into from
Nov 4, 2021
Merged

fix: handle failed global node_modules resolution #314

merged 1 commit into from
Nov 4, 2021

Conversation

adalinesimonian
Copy link
Member

Partially fixes #312

  • Errors encountered while attempting to run a package manager command no longer result in the entire path resolution failing. Instead, errors are now logged and undefined is returned.
  • Refactors the global path resolver implementation to accept a logger to be able to log more details about resolution errors.
  • Refactors the global path resolver into a class, similar to other components.
  • Removes the need for a custom global path resolver mock.
  • Removes the need for a separate type definition for the resolver as the class is able to provide sufficient type information.

@adalinesimonian
fix: handle failed global node_modules resolution
9e43b85 
- Errors encountered while attempting to run a package manager command
  no longer result in the entire path resolution failing. Instead,
  errors are now logged and `undefined` is returned.
- Refactors the global path resolver implementation to accept a logger
  to be able to log more details about resolution errors
- Refactors the global path resolver into a class, similar to other
  components.
- Removes the need for a custom global path resolver mock.
- Removes the need for a separate type definition for the resolver as
  the class is able to provide sufficient type information.
@adalinesimonian adalinesimonian added this to the v1.1.0 milestone Nov 4, 2021
@adalinesimonian adalinesimonian self-assigned this Nov 4, 2021
@adalinesimonian adalinesimonian added this to In progress in Rolling Work Tracking via automation Nov 4, 2021
@adalinesimonian adalinesimonian merged commit 77c0719 into main Nov 4, 2021
Rolling Work Tracking automation moved this from In progress to Done Nov 4, 2021
@adalinesimonian adalinesimonian deleted the graceful-package-manager-error branch November 4, 2021 20:30
@adalinesimonian adalinesimonian mentioned this pull request Nov 4, 2021
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ntwb ntwb Awaiting requested review from ntwb

@ota-meshi ota-meshi Awaiting requested review from ota-meshi

Assignees

@adalinesimonian adalinesimonian

Labels
None yet
Projects
Rolling Work Tracking
Done
Milestone
v1.1.0
Development

Successfully merging this pull request may close these issues.

[Bug]: Extension can't find Stylelint on VS Code launched from outside the terminal
1 participant
@adalinesimonian