fix: actually enable FlatList props to be passed down to TimerPicker #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ah no worries, easily done! Should've spotted that when I reviewed it. And thank you for adding the test 👏 |
|
Have released the fix in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ops, my bad. 😅
I put the
FlatListprop in the destructuring, but then I forgot to passed it down explicitly, so it wasn't working.I removed the declaration so it ends up inside
otherProps.I didn't spot it because I was working with a copy of the source code in my main project and then I replicated the changes on the original repo 🤦
I added a simple test to make up for it 😁