This repository has been archived by the owner on Mar 5, 2024. It is now read-only.
Idiamond metrics #131
Merged
Idiamond metrics #131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Replace go-metrics Prometheus metrics with the Prometheus go client library - Replace go-metrics statsd with a client that does not perform in memory aggregation - Add additional logging as to the duration of requests
* reorder interceptors to capture client metrics * document client metrics that'll be exported for the agent
Codecov Report
@@ Coverage Diff @@
## master #131 +/- ##
=========================================
+ Coverage 38.15% 38.86% +0.7%
=========================================
Files 21 24 +3
Lines 815 831 +16
=========================================
+ Hits 311 323 +12
- Misses 475 480 +5
+ Partials 29 28 -1
|
This was referenced Aug 2, 2018
|
If someone from @uswitch/cloud could take a look and see what you think- I think this should be the last thing needed before we push out an RC and start testing in some of our clusters. |
docs/metrics.md
Outdated
| system, check the timing of each RPC call, and monitor the size of the | ||
| credentials cache. By default, Prometheus metrics are exported on | ||
| `localhost:9620` and StatsD metrics are sent to `127.0.0.1:8125`. StatsD | ||
| metrics are not aggregated and flushed every 100ms. |
There was a problem hiding this comment.
are not aggregated and flushed every 100ms. I think that should be "are not aggregated and are flushed every 100ms"
Joseph-Irving
approved these changes
Aug 3, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This builds upon the work by @idiamond-stripe to improve handling of Prometheus and StatsD metrics.
It renames some of the metrics @idiamond-stripe introduced to bring them closer in line with the naming recommendations (
_totalonly for counters etc.).Currently gRPC Client metrics (those exported within the agent) don't report correctly- once that's fixed this can be merged.