Skip to content
This repository has been archived by the owner on Mar 5, 2024. It is now read-only.

Delete statsd #431

Merged
merged 1 commit into from
Oct 19, 2020
Merged

Delete statsd #431

merged 1 commit into from
Oct 19, 2020

Conversation

pingles
Copy link
Contributor

@pingles pingles commented Oct 16, 2020

Inspired by #429 and other deprecation tidy-up, I thought this would be a good thing to consider.

I think it tidies up nicely.

@pingles pingles added this to the v4 milestone Oct 16, 2020
@pingles
Copy link
Contributor Author

pingles commented Oct 16, 2020

@Joseph-Irving what do you think?

@pingles pingles marked this pull request as ready for review October 16, 2020 22:30
@codecov
Copy link

codecov bot commented Oct 16, 2020

Codecov Report

Merging #431 into master will increase coverage by 0.95%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #431      +/-   ##
==========================================
+ Coverage   45.14%   46.09%   +0.95%     
==========================================
  Files          26       26              
  Lines        1070     1050      -20     
==========================================
+ Hits          483      484       +1     
+ Misses        532      514      -18     
+ Partials       55       52       -3     
Impacted Files Coverage Δ
pkg/aws/metadata/handler_credentials.go 83.72% <ø> (+3.72%) ⬆️
pkg/aws/metadata/handler_health.go 73.17% <ø> (+3.40%) ⬆️
pkg/aws/metadata/handler_role_name.go 84.31% <ø> (+3.18%) ⬆️
pkg/aws/sts/gateway.go 51.02% <ø> (+2.00%) ⬆️
pkg/server/gateway.go 0.00% <ø> (ø)
pkg/server/server.go 21.73% <ø> (+0.90%) ⬆️
pkg/server/tls.go 46.57% <0.00%> (+0.68%) ⬆️

Copy link
Contributor

@Joseph-Irving Joseph-Irving left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, Prometheus is the metrics standard these days, don't see any reason to carry this into v4.

@pingles pingles merged commit 94212a6 into master Oct 19, 2020
@pingles pingles deleted the remove-statsd branch October 19, 2020 08:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants