Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

showInlineError not working on ListField #100

Closed
jamielob opened this issue Sep 7, 2016 · 4 comments
Closed

showInlineError not working on ListField #100

jamielob opened this issue Sep 7, 2016 · 4 comments
Assignees
@radekmie
Labels
Type: Feature New features and feature requests
Projects
Open Source (migrated)

Comments

@jamielob
Copy link

jamielob commented Sep 7, 2016 •
edited
Loading

Getting an error that showInlineError prop isn't allowed on section. Looks like it's because the ListField component isn't wrapped in a FormGroup which is where the inline errors are handled?

To replicate, just create a ListField component with showInlineError as a prop.

p.s. Great package.
@radekmie radekmie added the Type: Feature New features and feature requests label Sep 9, 2016
@radekmie radekmie self-assigned this Sep 9, 2016
@radekmie
Copy link
Contributor

radekmie commented Sep 9, 2016

Well, yes - it's not passed down. If you want, create a PR for it (it's only two lines in two packages - 4 LOC). No matter what, it will be refactored - you can track progress in #87.

radekmie added a commit that referenced this issue Nov 2, 2016
@radekmie
Added showInlineError on the form (closes #87, #100).
a4a0a9d
@radekmie radekmie closed this as completed Nov 2, 2016
@radekmie
Copy link
Contributor

radekmie commented Nov 2, 2016

Now it's propagated like disabled, so setting it on ListField will set it on the nested fields.

@radekmie
Copy link
Contributor

radekmie commented Nov 2, 2016

OK, now I see, that this is not the case...

@radekmie radekmie reopened this Nov 2, 2016
@radekmie
Copy link
Contributor

radekmie commented Nov 2, 2016

Implemented in d4fadf8.

@radekmie radekmie closed this as completed Nov 2, 2016
@Monteth Monteth added this to Closed in Open Source (migrated) Jun 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@radekmie radekmie

Labels
Type: Feature New features and feature requests
Projects
Open Source
Archived in project
Open Source (migrated)
Closed
Milestone
No milestone
Development

No branches or pull requests
2 participants
@radekmie @jamielob