-
-
Notifications
You must be signed in to change notification settings - Fork 239
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Material UI 5 Adapter #1054
Comments
Hi @guyathomas, |
(We've had a team discussion about this issue, and here are the notes.)
|
We did it here: https://github.com/comediadesign/uniforms-mui-5 mostly fixing imports and props but also remove the tests since we didn't bother migrating all of them 😬 I've been using it for 2 months, and we didn't have any issues with it (yet...) |
That's great @boertel! We have a meeting today and we'll check out your package. Would you be interested in maintaining it yourself, or maybe transfer it here? |
I'm a contractor working on a project so I don't see myself maintaining it but I'm happy to transfer it! |
We'll try the codemod first and if it'll take too much time, we'll ask you for help. Separately, we'll contact you about the package name on npm later. |
@Floriferous @guyathomas @boertel Just FYI: We have started working on implementing MUI v5 theme in uniforms. So far the codemod has worked really well and a large portion of work is already done. We will be posting updates on our progress as we go. |
Any update on this progress? |
@wadamek65 How is it going? |
@wadamek65 The PR is finished and awaiting reviews and testing. Feel free to review it yourself if you'd like to participate and help us out! |
@wadamek65 Thank you for your update.
I check the node_modules/uniforms-mui directory, |
@wadamek65 I've got it. I need to run |
then I had this error:
I works well with the |
@minhna Sounds like it might be an issue with a duplicate version of the package installed. Please try cleaning all |
@wadamek65 I tried but it didn't solve the problem.
and defind the schema
|
@minhna Installing uniforms locally from the repo may be a problem, just as you saw. Until we update the documentation on that, you can try simply copy-pasting the theme's source into your project (assuming it's capable of working with TypeScript). |
Hi @radekmie Do you know when the pull request got merged? Thank you. |
@minhna Definitely today, most likely in the next few hours. (I wanted to do it on Friday, but something came up.) |
@radekmie OMG. It's the best news today. |
Released in v3.10.0-rc.0. |
Material UI 5 is finally out of Alpha and it would be great to leverage it.
https://mui.com/getting-started/usage/
The text was updated successfully, but these errors were encountered: