Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug: checkbox label doubled & needs spacing between checkbox and label #35

Closed
zeroasterisk opened this issue Jun 17, 2016 · 1 comment
Closed

bug: checkbox label doubled & needs spacing between checkbox and label #35

zeroasterisk opened this issue Jun 17, 2016 · 1 comment
Assignees
@radekmie
Labels
Type: Feature New features and feature requests
Projects
Open Source (migrated)

Comments

@zeroasterisk
Copy link
Contributor

We need to be able to control the checkbox field better.

  • We should default to no label on the left (in the FormGroup)
  • We should allow a schema defined custom label on the left (?prop: labelLeft ?)
  • We should add a   after the input and before the label on the right.

ss
zeroasterisk added a commit to zeroasterisk/uniforms that referenced this issue Jun 17, 2016
@zeroasterisk
re vazco#35 add space between checkbox/label
265d4ce
zeroasterisk added a commit to zeroasterisk/uniforms that referenced this issue Jun 17, 2016
@zeroasterisk
re vazco#35 modify label left idea (DRAFT)
5d5e70e
zeroasterisk added a commit to zeroasterisk/uniforms that referenced this issue Jun 17, 2016
@zeroasterisk
re vazco#35 left label modify, working example
a520ee0
@radekmie
Copy link
Contributor

Okay, so:

  1. We should default to no label on the left (in the FormGroup)
    I'll comment Added labelBefore to bootstrap themes #36.
  2. We should allow a schema defined custom label on the left (?prop: labelLeft ?)
    It's already done because we have uniforms key in SimpleSchema and it will be merged with props. In my opinion labelLeft is not adequate, because sometimes it is above the field. How about labelBefore?
  3. We should add a   after the input and before the label on the right.
    It's covered in Fixed label spacing in bootstrap themes #37, and surely will be merged.

@radekmie radekmie self-assigned this Jun 17, 2016
@radekmie radekmie added the Type: Feature New features and feature requests label Jun 17, 2016
zeroasterisk added a commit to zeroasterisk/uniforms that referenced this issue Jun 27, 2016
@zeroasterisk
re vazco#35 add space between checkbox/label x2
54bfd4b 
Add space for semantic & unstyled too
zeroasterisk added a commit to zeroasterisk/uniforms that referenced this issue Jun 27, 2016
@zeroasterisk
Revert "re vazco#35 add space between checkbox/label"
505c191 
This reverts commit 265d4ce.
radekmie pushed a commit that referenced this issue Jun 28, 2016
@zeroasterisk @radekmie
Bootstrap3/4 labelLeft
c4e54e6 
* Bool labelBefore
* Bool labelBefore fix re #36
* re #35 add space between checkbox/label
* re #35 modify label, idea (DRAFT)
* re #35 modify label, working example
@Monteth Monteth added this to Closed in Open Source (migrated) Jun 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@radekmie radekmie

Labels
Type: Feature New features and feature requests
Projects
Open Source
Archived in project
Open Source (migrated)
Closed
Milestone
No milestone
Development

No branches or pull requests
2 participants
@zeroasterisk @radekmie