Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Invalid id #671

Closed
metamn opened this issue Dec 18, 2019 · 1 comment · Fixed by #672
Closed

Invalid id #671

metamn opened this issue Dec 18, 2019 · 1 comment · Fixed by #672
Assignees
@kestarumper
Labels
Type: Bug Bug reports and their fixes
Projects
Open Source (migrated)

Comments

@metamn
Copy link

metamn commented Dec 18, 2019

Hello,

I've just run the example from: #549
In the generated form we have:

<div class="ui checkbox"><input id="uniforms-0000-0001-Impact One" name="impact" type="checkbox"><label for="uniforms-0000-0001-Impact One">Impact One</label></div>

uniforms-0000-0001-Impact One contains a whitespace which is invalid: https://developer.mozilla.org/en-US/docs/Web/HTML/Global_attributes/id
@radekmie radekmie added this to Needs triage in Open Source (migrated) Dec 18, 2019
@kestarumper kestarumper self-assigned this Dec 18, 2019
@kestarumper kestarumper added the Type: Bug Bug reports and their fixes label Dec 18, 2019
@kestarumper kestarumper moved this from Needs triage to To do in Open Source (migrated) Dec 18, 2019
@kestarumper
Copy link
Member

Hi @metamn,
Yes, you are right, this is a bug. We'll get to it soon.

@kestarumper kestarumper mentioned this issue Dec 18, 2019
Merged
Open Source (migrated) automation moved this from To do to Closed Dec 18, 2019
radekmie pushed a commit that referenced this issue Dec 18, 2019
@kestarumper @radekmie
Escaped id attributes (fixes #671).
6a30de6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kestarumper kestarumper

Labels
Type: Bug Bug reports and their fixes
Projects
Open Source
Archived in project
Open Source (migrated)
Closed
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Correct attribute id format (fixes #671). vazco/uniforms
2 participants
@metamn @kestarumper