Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validation is not triggered in antd Selection (v3) #769

Closed
pro-kswe opened this issue Jul 22, 2020 · 1 comment
Closed

Validation is not triggered in antd Selection (v3) #769

pro-kswe opened this issue Jul 22, 2020 · 1 comment
Assignees
Labels
Type: Bug Bug reports and their fixes
Milestone

Comments

@pro-kswe
Copy link

Thanks for this awesome lib and the update to v3 and antd v4! Currently, I try to migrate to uniforms v3. I think I found a regression bug. When using a selection field, the validation is not (re)triggered after changing the value. This can be reproduced with the help of the playground. Go to

https://uniforms.tools/playground/#?N4IgDgTgpgzlAuIBcIDqUA2BjA9gWygEIQAacCHMGZUAQwFd4cZaA3KZAM1ozjIaYt2AEUy0AnsgCMABhlkAJgEsWAIwxQFXHnxAZaqzMngR6UMmH1YoACxwYFUCNt7mQMLDah5ayEADsoAHcAAgBlJTxLKDDPb1oAJgAhCCUFAHMoAAoAHX8QgpDA0IiojVivHyzgPMK6kIVaeCgkEJr8-s74cTAWkOEm81rO-sduegx4ADUeM1bi_sGsgEphzoBfEjy1-toFCfhW9pH67t7WpJx7KFp_HbrN7Y7OmCUALz7jk8KzvrCTJT-dJbZ7fMYMSYzDBzEIAcjwsJB30KPAwOCCmihZhgrQA2rCAB4wRFw4kkOEI8mwjAkwk0gC690KjzuoLqECagPSRyZXR6fQAcvQ8IYIEjkSFUejMbNYHipOSEuSAMzkgAs5IArPTxcj6P4lJwcBA8Di2rzvnEsABrVQ4AlykImMwWh4WlkWzipKD-BRmr7I36tACCEA54l13zwgIAwjh9YcQlJ3SCLbCvUofX6AHQAElhPLZIyDIQA8qoAFZQLDwFNPE7p72-mB57P-WgEAvmot887hAFAyMnaP-VrKuushsZrMt3PZ2iZLsB74loUipxDkYj1ryV2FHwE1pSTUyd07darfzLUjuOxBACS_gwgKgAFEw8aXLpaDBxP4sKW_hhPQqjRogSDcK4_C_v-gFQmkgxflAmwgPAlQcCgtzwFo6xAA

Change the size field to

 size: {
            type: String,
            allowedValues: ['xs', 's', 'm', 'l', 'xl']
        },
  1. Press the Submit button (no size selection done). => The size selection field is invalid (red).
  2. Choose a size. => The size selection field is (still) invalid (red).

Expectation: After changing to a valid value, the field should turn into a valid state (none red).

I think this was the case with v2.

Thanks
Oliver

@radekmie radekmie self-assigned this Jul 22, 2020
@radekmie radekmie added the Type: Bug Bug reports and their fixes label Jul 22, 2020
@radekmie radekmie added this to Needs triage in Open Source (migrated) via automation Jul 22, 2020
@radekmie radekmie added this to the v3.0 milestone Jul 22, 2020
@radekmie
Copy link
Contributor

radekmie commented Jul 22, 2020

Hi @pro-kswe and thanks for the report! Yes, it's a bug. Here's a minimal reproduction. For some reason, first change does not remove the validation error but if you'll do it once more - it works. EDIT: Not only in uniforms-antd - all themes are affected.

@radekmie radekmie moved this from Needs triage to To do in Open Source (migrated) Jul 26, 2020
@radekmie radekmie moved this from To do to In progress in Open Source (migrated) Jul 26, 2020
Open Source (migrated) automation moved this from In progress to Closed Jul 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Bug reports and their fixes
Projects
Archived in project
Development

No branches or pull requests

2 participants