Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

graphql@15 breaks uniforms #781

Closed
alexanderlperez opened this issue Aug 9, 2020 · 1 comment · Fixed by #784
Closed

graphql@15 breaks uniforms #781

alexanderlperez opened this issue Aug 9, 2020 · 1 comment · Fixed by #784
Assignees
Labels
Type: Feature New features and feature requests
Milestone

Comments

@alexanderlperez
Copy link

NOTE: reposted from gitter at request of @radekmie

At: https://gitter.im/vazco/uniforms?at=5f2fecd865e829425e708c7a

As I quickly checked, the playground you've created is using graphql@15 but uniforms are not yet updated. I mean, it'll for 99.9% just work, but due to the way how npm resolves modules, your type (got from getType) is not an instance of the same type in uniforms, because uniforms import a separate copy of graphql@14. Please file an issue and we'll take care of it in the following week.


I've been trying to get a basic example running on codesandbox (https://codesandbox.io/s/agitated-rgb-3vlrr?file=/src/App.js) using graphql@15 and the graphql bridge, but am getting Unsupported field type: String! for the single field in the schema.

The example works in the uniforms playground.

Playground sample:

new GraphQLBridge(buildASTSchema(parse(`
type Log {
    title:   String!
}

type Query { anything: ID }
`)).getType('Log'), function (model) {}, {})
@radekmie radekmie added this to Needs triage in Open Source (migrated) Aug 12, 2020
@radekmie radekmie self-assigned this Aug 12, 2020
@radekmie radekmie added the Type: Feature New features and feature requests label Aug 12, 2020
@radekmie radekmie moved this from Needs triage to To do in Open Source (migrated) Aug 12, 2020
@radekmie radekmie moved this from To do to In progress in Open Source (migrated) Aug 12, 2020
@radekmie
Copy link
Contributor

Hi @alexanderlperez! Thanks for filing this issue. I'm already on it.

@radekmie radekmie linked a pull request Aug 12, 2020 that will close this issue
Open Source (migrated) automation moved this from In progress to Closed Aug 12, 2020
@radekmie radekmie added this to the v3.0 milestone Apr 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Feature New features and feature requests
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants