Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow passing showInlineError to AutoFields component #827

Closed
Floriferous opened this issue Nov 13, 2020 · 2 comments · Fixed by #927
Closed

Allow passing showInlineError to AutoFields component #827

Floriferous opened this issue Nov 13, 2020 · 2 comments · Fixed by #927
Assignees
Labels
Type: Feature New features and feature requests
Milestone

Comments

@Floriferous
Copy link
Contributor

I would expect to be able to set showInlineError on the AutoFields component, and have it pass down to each AutoField, just like you can do this with showInlineError on the AutoForm component.

There might be other props like this that you can set on AutoForm, but not on AutoFields?

@radekmie radekmie added this to Needs triage in Open Source (migrated) Nov 13, 2020
@radekmie radekmie self-assigned this Nov 20, 2020
@radekmie radekmie added the Type: Question Questions and other discussions label Nov 20, 2020
@radekmie radekmie moved this from Needs triage to In progress in Open Source (migrated) Nov 20, 2020
@radekmie
Copy link
Contributor

Hi @Floriferous. I'd like to know your exact use case because I have never had a situation, where I'd like to do that. I always enable it for the whole form or for a single field. Also, would it make sense to accept all other props instead?

@Floriferous
Copy link
Contributor Author

Yeah, for me it's just a question of DX, making the uniforms API a bit more forgiving.

Indeed, passing all the relevant props down on AutoForm and AutoFields would be great.

@radekmie radekmie added the Type: Feature New features and feature requests label Nov 22, 2020
@radekmie radekmie moved this from In progress to To do in Open Source (migrated) Nov 22, 2020
@radekmie radekmie added this to the v3.x milestone Nov 22, 2020
@radekmie radekmie removed the Type: Question Questions and other discussions label Nov 22, 2020
@radekmie radekmie modified the milestones: v3.x, v3.1 Jan 22, 2021
@radekmie radekmie modified the milestones: v3.1, v3.2 Feb 3, 2021
@radekmie radekmie modified the milestones: v3.2, v3.3 Feb 17, 2021
@Monteth Monteth linked a pull request Apr 9, 2021 that will close this issue
@Monteth Monteth assigned Monteth and unassigned radekmie Apr 9, 2021
@Monteth Monteth moved this from To do to In progress in Open Source (migrated) Apr 14, 2021
Open Source (migrated) automation moved this from In progress to Closed Apr 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Feature New features and feature requests
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants