Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JSONSchemaBridge in combination with ajv-validator v8 not working, while v7 is #923

Closed
petermanders89 opened this issue Apr 7, 2021 · 1 comment · Fixed by #925
Closed

JSONSchemaBridge in combination with ajv-validator v8 not working, while v7 is #923

petermanders89 opened this issue Apr 7, 2021 · 1 comment · Fixed by #925
Assignees
@Monteth
Labels
Type: Feature New features and feature requests
Projects
Open Source (migrated)
Milestone
v3.4

Comments

@petermanders89
Copy link

The bridge is no longer working with the new version of the ajv-validator (see ajv-validator/ajv#1487). The property 'dataPath' has been renamed to 'instancePath'.

uniforms/packages/uniforms-bridge-json-schema/src/JSONSchemaBridge.ts

Line 97 in 657ad91

const path = pathToName(detail.dataPath);

This affects: JSONSchemaBridge in combination with the 'ajv-validator'.
@radekmie radekmie added the Type: Bug Bug reports and their fixes label Apr 8, 2021
@radekmie radekmie added this to Needs triage in Open Source (migrated) via automation Apr 8, 2021
@radekmie radekmie added this to the v3.3 milestone Apr 8, 2021
@radekmie radekmie moved this from Needs triage to To do in Open Source (migrated) Apr 8, 2021
@radekmie radekmie added Type: Feature New features and feature requests and removed Type: Bug Bug reports and their fixes labels Apr 8, 2021
@radekmie radekmie modified the milestones: v3.3, v3.4 Apr 8, 2021
@radekmie
Copy link
Contributor

radekmie commented Apr 8, 2021

Hi @petermanders89. That's right, we have to update the JSONSchemaBridge. Thanks for the report!

This was referenced Apr 9, 2021
Merged
Merged
@Monteth Monteth linked a pull request Apr 9, 2021 that will close this issue
Add Ajv v8 support in uniforms-bridge-json-schema (closes #923). #925
Merged
@Monteth Monteth moved this from To do to In progress in Open Source (migrated) Apr 9, 2021
Open Source (migrated) automation moved this from In progress to Closed Apr 16, 2021
radekmie pushed a commit that referenced this issue Apr 16, 2021
@Monteth
Added Ajv v8 support in uniforms-bridge-json-schema (closes #923).
3c7d0c5
@radekmie radekmie mentioned this issue Apr 20, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Monteth Monteth

Labels
Type: Feature New features and feature requests
Projects
Open Source
Archived in project
Open Source (migrated)
Closed
Milestone
v3.4
Development

Successfully merging a pull request may close this issue.

Add Ajv v8 support in uniforms-bridge-json-schema (closes #923). vazco/uniforms
3 participants
@radekmie @Monteth @petermanders89