Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inconsistent GraphQLBridge error logic. #950

Closed
wadamek65 opened this issue May 7, 2021 · 0 comments · Fixed by #956
Closed

Inconsistent GraphQLBridge error logic. #950

wadamek65 opened this issue May 7, 2021 · 0 comments · Fixed by #956
Assignees
@radekmie
Labels
Type: Bug Bug reports and their fixes
Projects
Open Source (migrated)
Milestone
v3.5

Comments

@wadamek65
Copy link
Contributor

The way we handle errors in GraphQLBridge is inconsistent with other bridges. There is one unnecessary if statement in getErrorMessages function that will cause null value to be treated as an error. Part of code in question
@wadamek65 wadamek65 added the Type: Bug Bug reports and their fixes label May 7, 2021
@wadamek65 wadamek65 self-assigned this May 7, 2021
@radekmie radekmie added this to the v3.5 milestone May 12, 2021
@radekmie radekmie assigned radekmie and unassigned wadamek65 May 12, 2021
@radekmie radekmie moved this from To do to In progress in Open Source (migrated) May 12, 2021
radekmie added a commit that referenced this issue May 12, 2021
@radekmie
Unified getErrorMessages across bridges (fixes #950).
0a31af6
@radekmie radekmie mentioned this issue May 12, 2021
Merged
Open Source (migrated) automation moved this from In progress to Closed May 13, 2021
radekmie added a commit that referenced this issue May 13, 2021
@radekmie
Unified getErrorMessages across bridges (fixes #950).
498ec32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@radekmie radekmie

Labels
Type: Bug Bug reports and their fixes
Projects
Open Source
Archived in project
Open Source (migrated)
Closed
Milestone
v3.5
Development

Successfully merging a pull request may close this issue.

Unified getErrorMessages across bridges (fixes #950). vazco/uniforms
2 participants
@radekmie @wadamek65