Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI Enhancements #2

Closed
vinitshahdeo opened this issue Dec 31, 2019 · 13 comments · Fixed by #12
Closed

UI Enhancements #2

vinitshahdeo opened this issue Dec 31, 2019 · 13 comments · Fixed by #12
Assignees
Labels

Comments

@vinitshahdeo
Copy link
Owner

vinitshahdeo commented Dec 31, 2019

The current UI is using static HTML. Come up with an attractive UI containing animation to display the level of water in different tanks.

Screenshot 2019-12-31 at 9 06 14 PM

For animation, it's suggested to use the existing library: createWaterBall-jquery.js. See the demo here.

NOTE: Before writing UI element, please post a rough wireframe here and proceed to the development after the approval.

@vinitshahdeo vinitshahdeo added good first issue Good for newcomers help wanted Extra attention is needed very easy very easy issue easy Easy issue JWoC and removed very easy very easy issue labels Dec 31, 2019
@srijande srijande mentioned this issue Jan 25, 2020
11 tasks
@srijande
Copy link

I have submitted pr #12 .
please review and merge.

@vinitshahdeo
Copy link
Owner Author

@thesrijande Thanks for the PR. I see bare minimum changes in code, can you please add some more UI elements and update the PR. Take your time and build a better UI.

@srijande
Copy link

I have done some changes, please review again my pr.

@vinitshahdeo
Copy link
Owner Author

@thesrijande Thanks for the changes, can you please update the PR description with the relevant screenshots of UI?

@vinitshahdeo vinitshahdeo added gssoc20 Welcome to GirlScript Summer of Code 2020 and removed JWoC labels Feb 24, 2020
@aakankshamudgal
Copy link

I would like to work on this issue can you please assign it to me. I have some ideas regarding the same.

@saks1209am
Copy link

Please assign this issue to me. I can change the UI and make it look appealing

@saks1209am
Copy link

@vinitshahdeo I did some changes in the UI. Please go through it

water

@anushka-12-lal
Copy link

Hi, can I work on this issue?

@iBruceW
Copy link

iBruceW commented Apr 5, 2020

@vinitshahdeo @PragatiVerma18 Hi, I want to work on this issue. Can you please assign this to me?

@Ruchika30
Copy link

If this isn't taken up I can look into it ? @vinitshahdeo

@vinitshahdeo
Copy link
Owner Author

@Ruchika30 Hey, please check once with @PragatiVerma18 @jainpawan21. This issue has multiple tasks associated with it.

@PragatiVerma18
Copy link
Contributor

@Ruchika30 and @iBruceW, can you both please elaborate your UI improvement suggestions before I can assign this issue to any of you.

@Ruchika30
Copy link

Hi @PragatiVerma18 would u pls help me so as to which branch I need to take pull...is it /frontend?

vinitshahdeo pushed a commit that referenced this issue May 9, 2020
@vinitshahdeo vinitshahdeo added beginner friendly hacktoberfest easy pick and removed gssoc20 Welcome to GirlScript Summer of Code 2020 labels Sep 25, 2020
@Ruchika30 Ruchika30 removed their assignment Dec 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

9 participants