Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete unused variables. #3526

Closed
wants to merge 2 commits into from
Closed

Conversation

MichaelXcc
Copy link
Contributor

Delete unused variable: taskName, podToCreateEachTask.

@volcano-sh-bot volcano-sh-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 15, 2024
@googs1025
Copy link
Member

You can solve the DCO signature, use git commit -s

@MichaelXcc MichaelXcc force-pushed the master branch 3 times, most recently from 35986f5 to 5823742 Compare June 16, 2024 14:38
@MichaelXcc
Copy link
Contributor Author

/assign @shinytang6

@@ -73,7 +73,7 @@ tiers:
arguments:
sla-waiting-time: 1h2m3s4ms5µs6ns

Meanwhile, use can give individual job waiting time settings for one job via job annotations:
Meanwhile, user can give individual job waiting time settings for one job via job annotations:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is fixed in #3529

Signed-off-by: chuanX <cxu1995@hotmail.com>
@volcano-sh-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign shinytang6
You can assign the PR to them by writing /assign @shinytang6 in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@googs1025
Copy link
Member

You can rebase this commit directly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants