Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tentative first pass at making simulcast egest possible #312

Draft
wants to merge 38 commits into
base: master
Choose a base branch
from
Draft

Tentative first pass at making simulcast egest possible #312

wants to merge 38 commits into from

Commits on Oct 7, 2022

  1. Tentative first pass at making simulcast egest possible 

    This is not done "properly", and is an (almost) one for one copy of
changes from:

pion/webrtc@37e16a3
    @robashton
    robashton committed Oct 7, 2022
    Configuration menu
    Copy the full SHA
    2742632 View commit details
    Browse the repository at this point in the history

  2. Fix the tests (for now)

    @robashton
    robashton committed Oct 7, 2022
    Configuration menu
    Copy the full SHA
    d4160e1 View commit details
    Browse the repository at this point in the history

  3. clippy warnings (I guess I need to update/downgrade my rust)

    @robashton
    robashton committed Oct 7, 2022
    Configuration menu
    Copy the full SHA
    9fdf70b View commit details
    Browse the repository at this point in the history

Commits on Oct 10, 2022

  1. Re-instate changes from webrtc-rs#217

    @robashton
    robashton committed Oct 10, 2022
    Configuration menu
    Copy the full SHA
    ec670b4 View commit details
    Browse the repository at this point in the history

  2. Replace the mutex on track_encodings with a RwLock 

    (most of our operations are reads)
    @robashton
    robashton committed Oct 10, 2022
    Configuration menu
    Copy the full SHA
    4974cf4 View commit details
    Browse the repository at this point in the history

  3. Initial feedback from PR

    @robashton
    robashton committed Oct 10, 2022
    Configuration menu
    Copy the full SHA
    379f403 View commit details
    Browse the repository at this point in the history

Commits on Oct 11, 2022

  1. Make Rid an Option<String> and see how that falls out

    @robashton
    robashton committed Oct 11, 2022
    Configuration menu
    Copy the full SHA
    21607ac View commit details
    Browse the repository at this point in the history

  2. revert change to log (that I did when I was debugging my own stuff\!)

    @robashton
    robashton committed Oct 11, 2022
    Configuration menu
    Copy the full SHA
    a3c2a20 View commit details
    Browse the repository at this point in the history

  3. unique track ids in stats

    @robashton
    robashton committed Oct 11, 2022
    Configuration menu
    Copy the full SHA
    d6ff71d View commit details
    Browse the repository at this point in the history

  4. debug impl for TrackLocalContext

    @robashton
    robashton committed Oct 11, 2022
    Configuration menu
    Copy the full SHA
    d4c27fc View commit details
    Browse the repository at this point in the history

  5. ensure we only do simulcast send directives if we're doing a send on … 

    …this tranceiver
    @robashton
    robashton committed Oct 11, 2022
    Configuration menu
    Copy the full SHA
    19fc8e9 View commit details
    Browse the repository at this point in the history

  6. apparently format! is a thing

    @robashton
    robashton committed Oct 11, 2022
    Configuration menu
    Copy the full SHA
    acef0fd View commit details
    Browse the repository at this point in the history

  7. a few things in rtp_sender that we didn't ike

    @robashton
    robashton committed Oct 11, 2022
    Configuration menu
    Copy the full SHA
    ac59df1 View commit details
    Browse the repository at this point in the history

  8. unnecessary clone now it's an option

    @robashton
    robashton committed Oct 11, 2022
    Configuration menu
    Copy the full SHA
    4b04180 View commit details
    Browse the repository at this point in the history

  9. typo (got vimmed)

    @robashton
    robashton committed Oct 11, 2022
    Configuration menu
    Copy the full SHA
    246044e View commit details
    Browse the repository at this point in the history

Commits on Oct 13, 2022

  1. Tentative first pass at making simulcast egest possible 

    This is not done "properly", and is an (almost) one for one copy of
changes from:

pion/webrtc@37e16a3
    @robashton
    robashton committed Oct 13, 2022
    Configuration menu
    Copy the full SHA
    850fcb5 View commit details
    Browse the repository at this point in the history

  2. Fix the tests (for now)

    @robashton
    robashton committed Oct 13, 2022
    Configuration menu
    Copy the full SHA
    e20c15d View commit details
    Browse the repository at this point in the history

  3. clippy warnings (I guess I need to update/downgrade my rust)

    @robashton
    robashton committed Oct 13, 2022
    Configuration menu
    Copy the full SHA
    866965e View commit details
    Browse the repository at this point in the history

  4. Re-instate changes from webrtc-rs#217

    @robashton
    robashton committed Oct 13, 2022
    Configuration menu
    Copy the full SHA
    25cedc0 View commit details
    Browse the repository at this point in the history

  5. Replace the mutex on track_encodings with a RwLock 

    (most of our operations are reads)
    @robashton
    robashton committed Oct 13, 2022
    Configuration menu
    Copy the full SHA
    2972dd5 View commit details
    Browse the repository at this point in the history

  6. Initial feedback from PR

    @robashton
    robashton committed Oct 13, 2022
    Configuration menu
    Copy the full SHA
    55bc75c View commit details
    Browse the repository at this point in the history

  7. Make Rid an Option<String> and see how that falls out

    @robashton
    robashton committed Oct 13, 2022
    Configuration menu
    Copy the full SHA
    8a59116 View commit details
    Browse the repository at this point in the history

  8. revert change to log (that I did when I was debugging my own stuff\!)

    @robashton
    robashton committed Oct 13, 2022
    Configuration menu
    Copy the full SHA
    f780884 View commit details
    Browse the repository at this point in the history

  9. unique track ids in stats

    @robashton
    robashton committed Oct 13, 2022
    Configuration menu
    Copy the full SHA
    9707863 View commit details
    Browse the repository at this point in the history

  10. debug impl for TrackLocalContext

    @robashton
    robashton committed Oct 13, 2022
    Configuration menu
    Copy the full SHA
    ffad0b5 View commit details
    Browse the repository at this point in the history

  11. ensure we only do simulcast send directives if we're doing a send on … 

    …this tranceiver
    @robashton
    robashton committed Oct 13, 2022
    Configuration menu
    Copy the full SHA
    6b23661 View commit details
    Browse the repository at this point in the history

  12. apparently format! is a thing

    @robashton
    robashton committed Oct 13, 2022
    Configuration menu
    Copy the full SHA
    7853a8d View commit details
    Browse the repository at this point in the history

  13. a few things in rtp_sender that we didn't ike

    @robashton
    robashton committed Oct 13, 2022
    Configuration menu
    Copy the full SHA
    afe4dcb View commit details
    Browse the repository at this point in the history

  14. unnecessary clone now it's an option

    @robashton
    robashton committed Oct 13, 2022
    Configuration menu
    Copy the full SHA
    b64f163 View commit details
    Browse the repository at this point in the history

  15. typo (got vimmed)

    @robashton
    robashton committed Oct 13, 2022
    Configuration menu
    Copy the full SHA
    6a24250 View commit details
    Browse the repository at this point in the history

  16. don't hold onto that lock, or we hang

    @robashton
    robashton committed Oct 13, 2022
    Configuration menu
    Copy the full SHA
    fd84deb View commit details
    Browse the repository at this point in the history

  17. some more tweaks

    @robashton
    robashton committed Oct 13, 2022
    Configuration menu
    Copy the full SHA
    f5857dd View commit details
    Browse the repository at this point in the history

  18. merge from upstream

    @robashton
    robashton committed Oct 13, 2022
    Configuration menu
    Copy the full SHA
    5aa6864 View commit details
    Browse the repository at this point in the history

  19. Merge branch 'simulcast-egest' of github.com:robashton/webrtc into si… 

    …mulcast-egest
    @robashton
    robashton committed Oct 13, 2022
    Configuration menu
    Copy the full SHA
    6996968 View commit details
    Browse the repository at this point in the history

  20. removed comments

    @robashton
    robashton committed Oct 13, 2022
    Configuration menu
    Copy the full SHA
    7da6936 View commit details
    Browse the repository at this point in the history

  21. revert method order

    @robashton
    robashton committed Oct 13, 2022
    Configuration menu
    Copy the full SHA
    5007093 View commit details
    Browse the repository at this point in the history

  22. remove read_simulcast_rtcp as we can't see a reason why it needs to e… 

    …xist
    @robashton
    robashton committed Oct 13, 2022
    Configuration menu
    Copy the full SHA
    7114d5e View commit details
    Browse the repository at this point in the history

Commits on Oct 17, 2022

  1. Option<String> on structs, Option<&str> on traits (for rid anyway)

    @robashton
    robashton committed Oct 17, 2022
    Configuration menu
    Copy the full SHA
    7c03a11 View commit details
    Browse the repository at this point in the history