Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

One single direction per extmap #321

Merged
merged 4 commits into from
Oct 13, 2022
Merged

One single direction per extmap #321

merged 4 commits into from
Oct 13, 2022

Commits on Oct 12, 2022

  1. One single direction per extmap 

    SDP has the syntax: a=extmap:<id>/<direction> <uri>

The /<direction> part is optional (and rarely seen it in the wild).

The current MediaEngine API makes it seem like it's possible to
provide many directions for each map (it takes a Vec). This commit
changes that sov only single optional direction can be provided.

This simplifies internal matching logic and fixes a bug where setting
the transceiver direction `inactive`, would (incorrectly) result in no
extmaps matching for the m-line.
    @algesten
    algesten committed Oct 12, 2022
    Configuration menu
    Copy the full SHA
    0bfb264 View commit details
    Browse the repository at this point in the history

  2. Update changelog

    @algesten
    algesten committed Oct 12, 2022
    Configuration menu
    Copy the full SHA
    d4ef737 View commit details
    Browse the repository at this point in the history

  3. Clippy fix

    @algesten
    algesten committed Oct 12, 2022
    Configuration menu
    Copy the full SHA
    1edb4a7 View commit details
    Browse the repository at this point in the history

  4. Document direction behavior

    @algesten
    algesten committed Oct 12, 2022
    Configuration menu
    Copy the full SHA
    1fa5f23 View commit details
    Browse the repository at this point in the history