Fix usePlotBandLifecycle calling invalid function

whawker · Sep 27, 2019 · 41c028d · 41c028d
1 parent 1cd20a9
commit 41c028d
Show file tree

Hide file tree

Showing 3 changed files with 15 additions and 4 deletions.
diff --git a/packages/react-jsx-highcharts/src/components/PlotBandLine/usePlotBandLineLifecycle.js b/packages/react-jsx-highcharts/src/components/PlotBandLine/usePlotBandLineLifecycle.js
@@ -13,9 +13,9 @@ export default function usePlotBandLine(props, plotType) {
   const modifiedProps = useModifiedProps(rest);
 
   useEffect(() => {
-    if (!axis) return;
-    if (modifiedProps !== false && plotbandline) {
-      axis.removePlotLine(idRef.current);
+    if (!axis || !plotbandline) return;
+    if (modifiedProps !== false) {
+      axis.removePlotBandOrLine(idRef.current);
       const opts = {
         id: idRef.current,
         ...modifiedProps

diff --git a/packages/react-jsx-highcharts/test/components/PlotBandLine/PlotLine.spec.js b/packages/react-jsx-highcharts/test/components/PlotBandLine/PlotLine.spec.js
@@ -55,6 +55,17 @@ describe('<PlotLine />', () => {
       );
       expect(testContext.axisStubs.addPlotBandOrLine.mock.calls[0][0].id).toMatch(uuidRegex);
     });
+
+    it('removes and adds plotline when props change', () => {
+      const wrapper = mount(
+        <PlotLine id="myplotline" value={3} />
+      );
+      testContext.axisStubs.addPlotBandOrLine.mockClear();
+
+      wrapper.setProps({ value: 4});
+      expect(testContext.axisStubs.addPlotBandOrLine).toHaveBeenCalledTimes(1);
+      expect(testContext.axisStubs.removePlotBandOrLine).toHaveBeenCalledWith('myplotline');
+    });
   });
 
   describe('when unmounted', () => {

diff --git a/packages/react-jsx-highcharts/test/test-utils.js b/packages/react-jsx-highcharts/test/test-utils.js
@@ -35,7 +35,7 @@ export const createMockProvidedChart = () => {
 export const createMockAxis = ({ ...additional }) => ({
   ...additional,
   remove: jest.fn(),
-  addPlotBandOrLine: jest.fn(),
+  addPlotBandOrLine: jest.fn().mockImplementation(() => ({})),
   removePlotBandOrLine: jest.fn(),
   getExtremes: jest.fn(),
   setExtremes: jest.fn(),