Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export usePlotBandLine to be used as extension point #237

Merged
merged 5 commits into from
Sep 30, 2019

Conversation

anajavi
Copy link
Collaborator

@anajavi anajavi commented Sep 29, 2019

This allows library users to extend plotline within their own components.

As discussed in #228 (comment)

@codecov-io
Copy link

codecov-io commented Sep 30, 2019

Codecov Report

Merging #237 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master    #237   +/-   ##
======================================
  Coverage    90.9%   90.9%           
======================================
  Files          68      69    +1     
  Lines         869     869           
  Branches      158     158           
======================================
  Hits          790     790           
  Misses         66      66           
  Partials       13      13
Impacted Files Coverage Δ
...highcharts/src/components/PlotBandLine/PlotBand.js 100% <ø> (ø) ⬆️
packages/react-jsx-highcharts/src/index.js 100% <ø> (ø) ⬆️
...highcharts/src/components/PlotBandLine/PlotLine.js 100% <ø> (ø) ⬆️
...omponents/PlotBandLine/UsePlotBandLineLifecycle.js 100% <100%> (ø)
...sx-highcharts/src/components/PlotBandLine/index.js 100% <100%> (ø) ⬆️
...rts/src/components/PlotBandLine/UsePlotBandLine.js 100% <100%> (ø)
...s/src/components/PlotBandLine/PlotBandLineLabel.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0689aeb...0b6a1a6. Read the comment docs.

@whawker
Copy link
Owner

whawker commented Sep 30, 2019

Should the usePlotBandLineLifecycle.js file begin with a capital 'U' for consistency?

@anajavi
Copy link
Collaborator Author

anajavi commented Sep 30, 2019

Should the usePlotBandLineLifecycle.js file begin with a capital 'U' for consistency?

I can rename all these. I just named it after a function name, as react kind of forces hook functions to start with uncapitalized 'use'.

During the rewrite I also thought about flattening the src directory structure, because most of the components don't need index.js anymore. Decided to suggest that later, as now it is still easy to see changes from classes to hooks on git.

@anajavi anajavi merged commit 0b83b60 into master Sep 30, 2019
@anajavi anajavi deleted the export-useplotbandline branch September 30, 2019 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants