-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Export usePlotBandLine to be used as extension point #237
Conversation
Codecov Report
@@ Coverage Diff @@
## master #237 +/- ##
======================================
Coverage 90.9% 90.9%
======================================
Files 68 69 +1
Lines 869 869
Branches 158 158
======================================
Hits 790 790
Misses 66 66
Partials 13 13
Continue to review full report at Codecov.
|
packages/react-jsx-highcharts/src/components/PlotBandLine/index.js
Outdated
Show resolved
Hide resolved
packages/react-jsx-highcharts/src/components/PlotBandLine/index.js
Outdated
Show resolved
Hide resolved
Should the |
I can rename all these. I just named it after a function name, as react kind of forces hook functions to start with uncapitalized 'use'. During the rewrite I also thought about flattening the src directory structure, because most of the components don't need index.js anymore. Decided to suggest that later, as now it is still easy to see changes from classes to hooks on git. |
This allows library users to extend plotline within their own components.
As discussed in #228 (comment)