Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use rules_antlr via bzlmod #137

Open
aignas opened this issue Jun 20, 2024 · 0 comments
Open

use rules_antlr via bzlmod #137

aignas opened this issue Jun 20, 2024 · 0 comments

Comments

@aignas
Copy link
Collaborator

aignas commented Jun 20, 2024

Currently depends on bazelbuild/bazel-central-registry#1575

wichert added a commit that referenced this issue Jun 20, 2024
With this change we start using `bzlmod` which should allow for better
developer experience and easier updates of the rules. With this we also
leverage `bazel-env` helper to setup tools to be in your `PATH`:
* Go: `go`, `gazelle`, `gopackagesdriver.sh`
* Bazel: `buildifier`, `buildozer`
* Python: `python`
* JAVA: `jar`, `java`

When updating the go dependencies only `go mod tidy` is required.

Summary:

* Enable bzlmod since it is reasonably stable with bazel 7.2.0.
* Move all of the available dependencies from WORKSPACE to bzlmod.
* Add pre-commit buildifier hooks using the pre-built binaries, should
  fix #128.
* Add bazel-env tool and modify the direnv to add more CLIs to the
  development environment. This includes the `gopackagesdriver` and
  others, from now on users should use `bazel run //:bazel-env` to setup
  their environment in addition to having `direnv`.
* Use the remote jdk17 toolchain for our builds.

NOTE: `rules_antlr4` cannot be migrated to `bzlmod` and I have opened
#137 to track this.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant