Allow switching between modes using the effect field #292
+5
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The minimum brightness value does not create a "range": it is only a limitation, e.g. by device capabilities. The range to be mapped is still (0, maximum). This also maps percentages to equal values between ranges.
Fix LocalTuyaLight brightness mapping
xZetsubou
reviewed
Jun 29, 2024
Co-authored-by: Bander <46300268+xZetsubou@users.noreply.github.com>
xZetsubou
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In general, Light entity model in HA has a design defect in both UI and automations: unlike Tuya, it does not allow to switch between modes (white, color, scene, music), keeping previous settings for the modes. It only allows to switch to a particular scene, a particular white temperature, a particular color. It is not a huge problem for a particular bulb, though it makes automations complicated. But, in case of a Light group, which consists of different bulbs, or bulbs with different settings (e.g. different colors) it makes impossible to group control switch between color/scene/white modes with pre-configured values for each bulb.
LocalTuya has a workaround for Music mode only.
This change allows to use "white", "color", "scene", "music" in Effect field of "Light 'Turn on'" action.
I also have a fix for UI, but I prefer to submit possibly arguable changes one by one.